Skip to content

Update repositories.txt #5434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update repositories.txt #5434

wants to merge 1 commit into from

Conversation

@gi0rg0sPapamichail
Copy link
Contributor

@gi0rg0sPapamichail gi0rg0sPapamichail commented Nov 15, 2024

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Nov 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

❌ ERROR: Arduino Lint found errors with https://github.com/Hyperion-Robotics/YDLiDaR_GS2:

Linting library in YDLiDaR_GS2
INFO: No header file found matching library name (YDLidar.h). Best practices are for primary header filename to match   
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name YDLidar is in use by a library in the Library Manager index. Each library must have a unique name   
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     
WARNING: Invalid category field value Sensor in library.properties                                             
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: Empty library.properties architectures field. Please define specific architectures or set to * if compatible   
         with all.                                                                                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP044)                                                                                                   

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in YDLiDaR_GS2/examples/ReadMeasurements

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @gi0rg0sPapamichail
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

per1234
per1234 reviewed Nov 16, 2024
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gi0rg0sPapamichail. I see you previously submitted this library (#5370), but with a different repository URL:

library-registry/repositories.txt

Line 4 in daafb6b

https://github.com/gi0rg0sPapamichail/YDLiDaR_GS2

We don't allow multiple registrations of the same library (even when it is hosted in multiple places), but we do allow library maintainers to request the repository URL of a library to be updated.

Please comment on this pull request thread to tell me if you would like to change the URL of the "YDLidar" from the current URL:

https://github.com/gi0rg0sPapamichail/YDLiDaR_GS2

To the new URL:

https://github.com/Hyperion-Robotics/YDLiDaR_GS2

@per1234 per1234 self-assigned this Nov 16, 2024
@per1234 per1234 added status: waiting for information More information must be provided before work can proceed status: changes requested Changes to PR are required before merge labels Nov 16, 2024
@per1234 per1234 mentioned this pull request Nov 16, 2024
Closed
per1234
per1234 reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of a tidy repository, I'm going to close this due to lack of activity.

@gi0rg0sPapamichail if you do want to request the library repository URL be changed, please submit another pull request, making sure to use the correct procedure this time:

https://github.com/arduino/library-registry#changing-the-url-of-a-library-already-in-library-manager

I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.

@per1234 per1234 closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 left review comments

Assignees

@per1234 per1234

Labels

status: changes requested Changes to PR are required before merge status: waiting for information More information must be provided before work can proceed topic: submission Add library to the list

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gi0rg0sPapamichail @per1234